Skip to content

magento-engcom/import-export-improvements#51: fix for uploader filepath#18810

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
webvisum:feature/importUploaderFilePath
Nov 6, 2018
Merged

magento-engcom/import-export-improvements#51: fix for uploader filepath#18810
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
webvisum:feature/importUploaderFilePath

Conversation

@staniag
Copy link
Copy Markdown

@staniag staniag commented Oct 25, 2018

Description (*)

Move call to _setUploadFile to after the initation of $this-> _directory

Fixed Issues (if relevant)

  1. Unable to instantiate the catalog import uploader with $filePath set magento-engcom/import-export-improvements#51

Manual testing scenarios (*)

  1. Using the factory pattern you instantiate the class Magento\CatalogImportExport\Model\Import\Uploader with $filePath defined

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Oct 25, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 25, 2018

Hi @sawebvisum. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Oct 25, 2018
@VladimirZaets
Copy link
Copy Markdown
Contributor

VladimirZaets commented Oct 25, 2018

Hi @sawebvisum, please, sign CLA, otherwise, we can't process your pull request

@staniag
Copy link
Copy Markdown
Author

staniag commented Oct 25, 2018

@VladimirZaets already assigned.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 25, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 25, 2018

Hi @VladimirZaets, thank you for the review.
ENGCOM-3274 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 25, 2018

@sawebvisum thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 35356ef into magento:2.3-develop Nov 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 6, 2018
ENGCOM-3274: magento-engcom/import-export-improvements#51: fix for up…
15e2a28 
…loader filepath #18810
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Nov 6, 2018

Hi @sawebvisum. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@dmanners dmanners mentioned this pull request Nov 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels

Component: CatalogImportExport Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@staniag @magento-cicd2 @magento-engcom-team @VladimirZaets